Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1881/modularization article treatment - Rearchitecture MWOffliner HTML/CSS/JS scraping (part #2) #1886

Merged
merged 9 commits into from
Sep 7, 2023
Merged

1881/modularization article treatment - Rearchitecture MWOffliner HTML/CSS/JS scraping (part #2) #1886

merged 9 commits into from
Sep 7, 2023

Conversation

VadimKovalenkoSNF
Copy link
Collaborator

@VadimKovalenkoSNF VadimKovalenkoSNF commented Aug 21, 2023 •
edited
Loading

Fixes #1881
Fixes #1830
Fixes #1872

@kelson42 kelson42 changed the title 1881/modularization article treatment 1881/modularization article treatment - Rearchitecture MWOffliner HTML/CSS/JS scraping (part #2) Aug 24, 2023
@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the 1881/modularization_article_treatment branch from 9beb58b to c4282bd Compare August 24, 2023 12:40
@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 81.40% and project coverage change: +0.20% 🎉

Comparison is base (fad1254) 71.60% compared to head (123e825) 71.80%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1886      +/-   ##
==========================================
+ Coverage   71.60%   71.80%   +0.20%     
==========================================
  Files          34       33       -1     
  Lines        2743     2774      +31     
  Branches      607      614       +7     
==========================================
+ Hits         1964     1992      +28     
- Misses        666      669       +3     
  Partials      113      113
Files Changed Coverage Δ
src/renderers/renderer.builder.ts 22.50% <ø> (ø)
src/util/categories.ts 0.00% <0.00%> (ø)
src/renderers/visual-editor.renderer.ts 55.55% <55.55%> (ø)
src/mwoffliner.lib.ts 73.60% <63.63%> (ø)
src/util/saveArticles.ts 72.58% <64.70%> (-5.73%) ⬇️
src/util/rewriteUrls.ts 83.10% <71.42%> (ø)
src/RedisStore.ts 74.60% <77.77%> (+0.05%) ⬆️
src/Downloader.ts 60.88% <78.78%> (+3.85%) ⬆️
src/renderers/abstract.renderer.ts 87.06% <87.06%> (ø)
src/renderers/wikimedia-desktop.renderer.ts 87.09% <87.09%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VadimKovalenkoSNF VadimKovalenkoSNF marked this pull request as ready for review August 25, 2023 14:08
kelson42
kelson42 requested changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@kelson42 kelson42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VadimKovalenkoSNF Looks good, but most of the work is not done (or I get it wrong?!) Where is all the part related to the HTML processing? Sorry, somehow I had not seen all the changes.

src/util/renderers/abstract.renderer.ts Outdated Show resolved Hide resolved
test/unit/saveArticles.test.ts Outdated Show resolved Hide resolved
kelson42
kelson42 reviewed Aug 27, 2023
View reviewed changes
src/Downloader.ts Outdated Show resolved Hide resolved
kelson42
kelson42 requested changes Aug 27, 2023
View reviewed changes
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, I see not oddity or anything schoking me. That said a few small things to improve and have open IMO an important discussion about the role and the articulation of the software around Dump.ts.

src/Downloader.ts Show resolved Hide resolved
src/util/renderers/visual-editor.renderer.ts Outdated Show resolved Hide resolved
kelson42
kelson42 requested changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things, but looks good in general.

src/Downloader.ts Show resolved Hide resolved
src/util/renderers/visual-editor.renderer.ts Outdated Show resolved Hide resolved
src/util/renderers/visual-editor.renderer.ts Outdated Show resolved Hide resolved
src/util/saveArticles.ts Outdated Show resolved Hide resolved
src/util/saveArticles.ts Outdated Show resolved Hide resolved
test/unit/bootstrap.ts Show resolved Hide resolved
@kelson42
Copy link
Collaborator

kelson42 commented Sep 5, 2023

I would also suggest to move src/util/renders to src/renders

@VadimKovalenkoSNF VadimKovalenkoSNF force-pushed the 1881/modularization_article_treatment branch from 231e403 to 12a4de9 Compare September 5, 2023 12:56
@kelson42
Copy link
Collaborator

kelson42 commented Sep 6, 2023

@VadimKovalenkoSNF If OK for a final review, then please request a new review. On my side it looks good, but would like to make a last review pass this evening.

@VadimKovalenkoSNF
Copy link
Collaborator Author

VadimKovalenkoSNF commented Sep 6, 2023 •
edited
Loading

I would also suggest to move src/util/renders to src/renders

Done

@VadimKovalenkoSNF
Copy link
Collaborator Author

Codefactor fixes are here - #1901

kelson42
kelson42 approved these changes Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@kelson42 kelson42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelson42 kelson42 merged commit 7174801 into main Sep 7, 2023
4 of 6 checks passed
@kelson42 kelson42 deleted the 1881/modularization_article_treatment branch September 7, 2023 06:53
@VadimKovalenkoSNF VadimKovalenkoSNF mentioned this pull request Sep 7, 2023
Merged
@Jaifroid Jaifroid mentioned this pull request Feb 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelson42 kelson42 kelson42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VadimKovalenkoSNF @kelson42 @code-factor